From: Andrew Morton <akpm@linux-foundation.org>
To: Shmulik Ladkani <shmulik@jungo.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: copy UART properties of UPF_FIXED_TYPE ports provisioned using early_serial_setup
Date: Wed, 28 Oct 2009 22:47:37 -0700 [thread overview]
Message-ID: <20091028224737.ac4279e7.akpm@linux-foundation.org> (raw)
In-Reply-To: <4AE57EDF.3040607@jungo.com>
On Mon, 26 Oct 2009 12:50:07 +0200 Shmulik Ladkani <shmulik@jungo.com> wrote:
> Augment the UPF_FIXED_TYPE logic, which currently applies to UART ports
> provisioned using platform_device_register.
>
> The suggested patch applies same logic into 'serial8250_register_ports',
> making UART ports provisioned using early_serial_setup inherit their
> properties from the uart_config entry.
>
> The patch applies to linux-2.6.32-rc5
>
> Signed-off-by: Shmulik Ladkani <shmulik@jungo.com>
> ---
> diff -upr linux-2.6.32-rc5.clean/drivers/serial/8250.c
> linux-2.6.32-rc5/drivers/serial/8250.c
> --- linux-2.6.32-rc5.clean/drivers/serial/8250.c 2009-10-16
> 02:41:50.000000000 +0200
> +++ linux-2.6.32-rc5/drivers/serial/8250.c 2009-10-26 11:36:09.000000000
> +0200
Your email client wordwraps the patches.
> @@ -2704,6 +2704,14 @@ serial8250_register_ports(struct uart_dr
> struct uart_8250_port *up = &serial8250_ports[i];
>
> up->port.dev = dev;
> +
> + if (up->port.flags & UPF_FIXED_TYPE) {
> + up->port.fifosize =
> + uart_config[up->port.type].fifo_size;
> + up->capabilities = uart_config[up->port.type].flags;
> + up->tx_loadsz = uart_config[up->port.type].tx_loadsz;
> + }
> +
> uart_add_one_port(drv, &up->port);
> }
> }
Why don't we also initialise up->port.type here?
Perhaps it would be neater to write a little function to do this rather
than copy-n-paste?
next prev parent reply other threads:[~2009-10-29 5:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 10:50 [PATCH] serial: copy UART properties of UPF_FIXED_TYPE ports provisioned using early_serial_setup Shmulik Ladkani
2009-10-29 5:47 ` Andrew Morton [this message]
2009-10-29 17:07 ` Shmulik Ladkani
[not found] <dzvMe-7Mg-3@gated-at.bofh.it>
2009-10-27 11:52 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028224737.ac4279e7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shmulik@jungo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).