From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Valentin Longchamp <valentin.longchamp@epfl.ch>,
s.hauer@pengutronix.de, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial imx.c: fix CTS trigger level lower to avoid lost chars
Date: Thu, 21 Jan 2010 22:11:33 +0000 [thread overview]
Message-ID: <20100121221133.GA30419@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20100121220653.GA21010@pengutronix.de>
On Thu, Jan 21, 2010 at 11:06:53PM +0100, Wolfram Sang wrote:
> CCing linux-serial
>
> On Thu, Jan 21, 2010 at 10:26:03PM +0100, Valentin Longchamp wrote:
> > The imx CTS trigger level is left at its reset value that is 32
> > chars. Since the RX FIFO has 32 entries, when CTS is raised, the
> > FIFO already is full. However, some serial port devices first empty
> > their TX FIFO before stopping when CTS is raised, resulting in lost
> > chars.
>
> ? Isn't that a flaw of the other side? Have you spotted other serial drivers
> doing the same as your patch?
Arguably, but it's common behaviour of 16550A's and similar.
next prev parent reply other threads:[~2010-01-21 22:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1264109163-28739-1-git-send-email-valentin.longchamp@epfl.ch>
2010-01-21 22:06 ` [PATCH] serial imx.c: fix CTS trigger level lower to avoid lost chars Wolfram Sang
2010-01-21 22:11 ` Russell King - ARM Linux [this message]
2010-01-22 10:14 ` Valentin Longchamp
2010-01-22 11:07 ` Jamie Lokier
2010-01-22 11:31 ` Russell King - ARM Linux
2010-01-22 11:49 ` Wolfram Sang
2010-01-22 16:47 ` Jamie Lokier
2010-01-22 16:47 ` Jamie Lokier
2010-01-22 16:57 ` Russell King - ARM Linux
2010-01-22 11:58 ` Wolfram Sang
2010-01-24 10:48 ` Valentin Longchamp
2010-05-05 9:47 ` Valentin Longchamp
2010-05-05 16:42 ` Greg KH
2010-05-05 23:48 ` patch serial-imx.c-fix-cts-trigger-level-lower-to-avoid-lost-chars.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121221133.GA30419@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=valentin.longchamp@epfl.ch \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).