linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Valentin Longchamp <valentin.longchamp@epfl.ch>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	Wolfram Sang <w.sang@pengutronix.de>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH] serial imx.c: fix CTS trigger level lower to avoid	lost chars
Date: Fri, 22 Jan 2010 11:07:01 +0000	[thread overview]
Message-ID: <20100122110701.GA15699@shareable.org> (raw)
In-Reply-To: <4B597A82.4020906@epfl.ch>

Valentin Longchamp wrote:
> First I wanted to fix the fact that the imx serial hardware only raises 
> the CTS pin when the oferflowing char begins to be set. I would have 
> solved this by setting the CTS trigger value to 31 instead of 32. But 
> when I talked with one colleague he told me about 16550A (that is 
> present nearly everywhere) that empty their TX FIFO, so I lowered it to 16.

That seems quite peculiar because a 16550A only has a 16 byte receive
buffer, doesn't it?  And therefore it would have trouble talking
reliably to another 16550A if it worked like that.  I wonder what I'm
not seeing in this picture.

-- Jamie

  reply	other threads:[~2010-01-22 11:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1264109163-28739-1-git-send-email-valentin.longchamp@epfl.ch>
2010-01-21 22:06 ` [PATCH] serial imx.c: fix CTS trigger level lower to avoid lost chars Wolfram Sang
2010-01-21 22:11   ` Russell King - ARM Linux
2010-01-22 10:14     ` Valentin Longchamp
2010-01-22 11:07       ` Jamie Lokier [this message]
2010-01-22 11:31         ` Russell King - ARM Linux
2010-01-22 11:49           ` Wolfram Sang
2010-01-22 16:47             ` Jamie Lokier
2010-01-22 16:47           ` Jamie Lokier
2010-01-22 16:57             ` Russell King - ARM Linux
2010-01-22 11:58 ` Wolfram Sang
2010-01-24 10:48   ` Valentin Longchamp
2010-05-05  9:47     ` Valentin Longchamp
2010-05-05 16:42       ` Greg KH
2010-05-05 23:48       ` patch serial-imx.c-fix-cts-trigger-level-lower-to-avoid-lost-chars.patch added to gregkh-2.6 tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100122110701.GA15699@shareable.org \
    --to=jamie@shareable.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=s.hauer@pengutronix.de \
    --cc=valentin.longchamp@epfl.ch \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).