public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Maxime Bizon <mbizon@freebox.fr>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	linux-serial@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] bcm63xx_uart: allow more than one uart to be registered.
Date: Sat, 30 Jan 2010 19:23:43 +0100	[thread overview]
Message-ID: <20100130182343.GA6971@pengutronix.de> (raw)
In-Reply-To: <1264873377-28479-3-git-send-email-mbizon@freebox.fr>

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

On Sat, Jan 30, 2010 at 06:42:57PM +0100, Maxime Bizon wrote:
> The bcm6358 CPU has two uarts, make it possible to use the second one.
> 
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> ---
>  drivers/serial/bcm63xx_uart.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/serial/bcm63xx_uart.c b/drivers/serial/bcm63xx_uart.c
> index f78ede8..6ab959a 100644
> --- a/drivers/serial/bcm63xx_uart.c
> +++ b/drivers/serial/bcm63xx_uart.c
> @@ -35,7 +35,7 @@
>  #include <bcm63xx_regs.h>
>  #include <bcm63xx_io.h>
>  
> -#define BCM63XX_NR_UARTS	1
> +#define BCM63XX_NR_UARTS	2
>  
>  static struct uart_port ports[BCM63XX_NR_UARTS];
>  
> @@ -784,7 +784,7 @@ static struct uart_driver bcm_uart_driver = {
>  	.dev_name	= "ttyS",
>  	.major		= TTY_MAJOR,
>  	.minor		= 64,
> -	.nr		= 1,
> +	.nr		= 2,

Err, why not using the #define here?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2010-01-30 18:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-30 17:42 bcm63xx_uart updates for 2.6.34 Maxime Bizon
2010-01-30 17:42 ` [PATCH 1/2] bcm63xx_uart: don't use kfree() on non kmalloced area Maxime Bizon
2010-01-30 17:42 ` [PATCH 2/2] bcm63xx_uart: allow more than one uart to be registered Maxime Bizon
2010-01-30 18:23   ` Wolfram Sang [this message]
2010-02-01 22:29     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100130182343.GA6971@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=gregkh@suse.de \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mbizon@freebox.fr \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox