From: Greg KH <greg@kroah.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Maxime Bizon <mbizon@freebox.fr>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-serial@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] bcm63xx_uart: allow more than one uart to be registered.
Date: Mon, 1 Feb 2010 14:29:19 -0800 [thread overview]
Message-ID: <20100201222919.GD19294@kroah.com> (raw)
In-Reply-To: <20100130182343.GA6971@pengutronix.de>
On Sat, Jan 30, 2010 at 07:23:43PM +0100, Wolfram Sang wrote:
> On Sat, Jan 30, 2010 at 06:42:57PM +0100, Maxime Bizon wrote:
> > The bcm6358 CPU has two uarts, make it possible to use the second one.
> >
> > Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> > ---
> > drivers/serial/bcm63xx_uart.c | 5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/serial/bcm63xx_uart.c b/drivers/serial/bcm63xx_uart.c
> > index f78ede8..6ab959a 100644
> > --- a/drivers/serial/bcm63xx_uart.c
> > +++ b/drivers/serial/bcm63xx_uart.c
> > @@ -35,7 +35,7 @@
> > #include <bcm63xx_regs.h>
> > #include <bcm63xx_io.h>
> >
> > -#define BCM63XX_NR_UARTS 1
> > +#define BCM63XX_NR_UARTS 2
> >
> > static struct uart_port ports[BCM63XX_NR_UARTS];
> >
> > @@ -784,7 +784,7 @@ static struct uart_driver bcm_uart_driver = {
> > .dev_name = "ttyS",
> > .major = TTY_MAJOR,
> > .minor = 64,
> > - .nr = 1,
> > + .nr = 2,
>
> Err, why not using the #define here?
Good idea, I've tweaked the patch to do that.
thanks,
greg k-h
prev parent reply other threads:[~2010-02-01 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-30 17:42 bcm63xx_uart updates for 2.6.34 Maxime Bizon
2010-01-30 17:42 ` [PATCH 1/2] bcm63xx_uart: don't use kfree() on non kmalloced area Maxime Bizon
2010-01-30 17:42 ` [PATCH 2/2] bcm63xx_uart: allow more than one uart to be registered Maxime Bizon
2010-01-30 18:23 ` Wolfram Sang
2010-02-01 22:29 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201222919.GD19294@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=mbizon@freebox.fr \
--cc=ralf@linux-mips.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox