From: Feng Tang <feng.tang@intel.com>
To: David Brownell <david-b@pacbell.net>
Cc: Erwin Authried <eauth@softsys.co.at>,
Baruch Siach <baruch@tkos.co.il>,
Greg Kroah-Hartman <gregkh@suse.de>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
spi-devel-list <spi-devel-general@lists.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>
Subject: Re: [spi-devel-general] [RFC][PATCH] serial: spi: add spi-uart driver for Maxim 3110
Date: Thu, 25 Feb 2010 15:49:06 +0800 [thread overview]
Message-ID: <20100225154906.7d3ac9f1@feng-i7> (raw)
In-Reply-To: <201002242047.14308.david-b@pacbell.net>
On Thu, 25 Feb 2010 12:47:13 +0800
David Brownell <david-b@pacbell.net> wrote:
> On Tuesday 29 December 2009, Erwin Authried wrote:
> > I think there's no need for a MAX3100 **and** a MAX3110 driver,
> > this is just confusing. The MAX3110 driver is identical to the
> > MAX3100 from the software view, it is simply a MAX3100 with
> > transceivers added to the chip. If there's any improvement, that
> > should be merged into the existing MAX3100 driver.
>
> Assuming that's true ... who will resolve the issue?
>
Hi David,
I've answered Erwin's comments before in v1 submission cycle, following
is the quote:
"I agree there should not be 2 drivers cover 1 family of HW, so this is a RFC.
I've thinked about merge with current 3100 code, but it depends on one char
per spi_transfer, while my driver relys on batch data transfer for efficiency.
Another key point is the console, SPI UART can't be directly accessed by
CPU, so every spi_transfer will go through tasklet/workqueue, which makes
supporting printk a big part of my driver."
I really did consider about that, but has no good clue, so I think better to
shape my driver first.
Thanks,
Feng
next prev parent reply other threads:[~2010-02-25 7:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 14:20 [RFC][PATCH] serial: spi: add spi-uart driver for Maxim 3110 Feng Tang
2009-12-29 14:59 ` [spi-devel-general] " Baruch Siach
2009-12-29 16:05 ` Tang, Feng
2009-12-29 18:43 ` Erwin Authried
2009-12-30 1:54 ` Feng Tang
2010-02-25 4:47 ` David Brownell
2010-02-25 7:49 ` Feng Tang [this message]
2009-12-29 15:02 ` Alan Cox
2010-02-08 8:59 ` [RFC][PATCH v2] " Feng Tang
2010-02-09 0:20 ` Andrew Morton
2010-02-09 0:26 ` Grant Likely
2010-02-09 1:36 ` Feng Tang
2010-02-17 22:58 ` Greg KH
2010-02-24 5:11 ` [RFC][PATCH v3] " Feng Tang
2010-02-24 10:44 ` Alan Cox
2010-02-24 14:25 ` Grant Likely
2010-02-24 23:18 ` Andrew Morton
2010-02-25 6:39 ` Feng Tang
2010-02-25 4:43 ` David Brownell
2010-02-25 7:44 ` Feng Tang
2010-02-25 8:11 ` David Brownell
2010-02-26 3:47 ` [PATCH v4] " Feng Tang
2010-02-26 9:59 ` Masakazu Mokuno
2010-02-26 19:41 ` David Brownell
2010-03-01 2:30 ` Feng Tang
2010-03-02 3:38 ` Feng Tang
2010-02-09 9:25 ` [RFC][PATCH v2] " Alan Cox
2010-03-03 2:57 ` [PATCH v5] " Feng Tang
2010-03-03 3:59 ` Grant Likely
2010-03-03 4:51 ` David Brownell
2010-03-03 5:52 ` Feng Tang
2010-03-03 6:16 ` David Brownell
2010-03-03 6:37 ` Feng Tang
2010-03-03 7:25 ` David Brownell
2010-03-03 7:42 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225154906.7d3ac9f1@feng-i7 \
--to=feng.tang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=baruch@tkos.co.il \
--cc=david-b@pacbell.net \
--cc=eauth@softsys.co.at \
--cc=gregkh@suse.de \
--cc=linux-serial@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).