linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: linux-serial@vger.kernel.org, nios2-dev@sopc.et.ntust.edu.tw,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/2] serial: Add driver for the Altera UART
Date: Fri, 26 Feb 2010 22:50:22 +0300	[thread overview]
Message-ID: <20100226195022.GF8417@bicker> (raw)
In-Reply-To: <1267109261-752-1-git-send-email-tklauser@distanz.ch>

A couple smatch complaints.

drivers/serial/altera_jtaguart.c
   380          if (co->index >= 0 && co->index <= ALTERA_JTAGUART_MAXPORTS)
   381                  co->index = 0;
   382          port = &altera_jtaguart_ports[co->index].port;

This test seems backward.  co->index == -1 would be a buffer underflow.

drivers/serial/altera_uart.c
   455          if ((co->index >= 0)
   456              && (co->index <= CONFIG_SERIAL_ALTERA_UART_MAXPORTS))
   457                  co->index = 0;
   458          port = &altera_uart_ports[co->index].port;

Same here.

regards,
dan carpenter

  reply	other threads:[~2010-02-26 19:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 14:35 [PATCH 1/2] serial: Add driver for the Altera JTAG UART Tobias Klauser
2010-02-25 14:35 ` [PATCH 2/2] serial: Add driver for the Altera UART Tobias Klauser
2010-02-25 14:47 ` [RESEND PATCH " Tobias Klauser
2010-02-26 19:50   ` Dan Carpenter [this message]
2010-03-01  8:04     ` Tobias Klauser
2010-02-25 15:26 ` [PATCH 1/2] serial: Add driver for the Altera JTAG UART Alan Cox
2010-02-26  9:04   ` Tobias Klauser
2010-02-26 11:27     ` Alan Cox
2010-02-25 16:45 ` Peter Korsgaard
2010-02-26  9:06   ` Tobias Klauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100226195022.GF8417@bicker \
    --to=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nios2-dev@sopc.et.ntust.edu.tw \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).