From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Govindraj.R" <govindraj.raja@ti.com>
Cc: Greg KH <greg@kroah.com>,
linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kevin Hilman <khilman@deeprootsystems.com>,
Tony Lindgren <tony@atomide.com>, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH] serial: Add OMAP high-speed UART driver.
Date: Mon, 1 Mar 2010 18:13:01 +0000 [thread overview]
Message-ID: <20100301181301.08d67b03@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <41322.192.168.10.89.1267454612.squirrel@dbdmail.itg.ti.com>
> + 213 = /dev/ttyO0 OMAP serial port 0
> + 214 = /dev/ttyO1 OMAP serial port 1
> + 215 = /dev/ttyO2 OMAP serial port 2
> + 216 = /dev/ttyO3 OMAP serial port 3
I think it might be best to allocate a dynamic tty major nowdays
Other problem is that I don't see where you hold the port lock over all
uses of port->tty. That is an assumption of the serial layer and done in
the original 8250 driver correctly.
Rest looks good and I agree that OMAP is different enough from 8250 that
it makes sense not to further clutter the 8250 driver.
next prev parent reply other threads:[~2010-03-01 18:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 14:43 [PATCH] serial: Add OMAP high-speed UART driver Govindraj.R
2010-03-01 18:13 ` Alan Cox [this message]
2010-03-01 18:46 ` Tony Lindgren
2010-03-02 5:51 ` G, Manjunath Kondaiah
2010-03-02 6:08 ` Tony Lindgren
2010-03-02 6:27 ` G, Manjunath Kondaiah
2010-03-02 6:52 ` Tony Lindgren
2010-03-02 13:46 ` Venkatraman S
2010-03-02 13:58 ` G, Manjunath Kondaiah
[not found] ` <E0D41E29EB0DAC4E9F3FF173962E9E94026ED96358@dbde02.ent.ti.com>
2010-03-02 14:04 ` Shilimkar, Santosh
[not found] ` <EAF47CD23C76F840A9E7FCE10091EFAB02C44C22F6@dbde02.ent.ti.com>
2010-03-02 15:03 ` G, Manjunath Kondaiah
2010-03-02 15:13 ` Shilimkar, Santosh
[not found] ` <EAF47CD23C76F840A9E7FCE10091EFAB02C44C2348@dbde02.ent.ti.com>
2010-03-03 5:26 ` G, Manjunath Kondaiah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301181301.08d67b03@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=govindraj.raja@ti.com \
--cc=greg@kroah.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=olof@lixom.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox