From: Paul Mundt <lethal@linux-sh.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Magnus Damm <damm@opensource.se>,
Dan Williams <dan.j.williams@intel.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 0/2] Implement DMA support for the sh-sci.c serial driver
Date: Tue, 2 Mar 2010 12:13:10 +0900 [thread overview]
Message-ID: <20100302031310.GC20256@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1002181624190.4373@axis700.grange>
On Thu, Feb 18, 2010 at 05:29:59PM +0100, Guennadi Liakhovetski wrote:
> The two patches in this series add DMA support to the sh-sci SCI(F) serial
> driver. The worst problem is partial reception. Since we don't know in
> advance how many bytes we're going to receive, we submit a DMA buffer
> _and_ enable the Rx interrupt. When data arrives, we get an interrupt and
> the data is written into DMA buffers. In the ISR we then set a timeout, if
> within this time we get no DMA completion callback, we have a partial
> buffer. Unfortunately, dmaengine API currently doesn't support retrieving
> partially received DMA buffers, therefore we have to hijack the
> .device_terminate_all() call to collect the data. A better approach would
> be to add a stop-transfer / collect-partial call to the API.
>
I've rolled these patches in as well, with some minor cleanups and
dependency fixups.
As none of the CPUs presently enable this yet, this will remain fairly
experimental, but it's enough to get people playing with it under 2.6.34.
We'll have to do some more iterative changes for 2.6.35, as well as
gradually getting it wired up on more CPUs, in addition to making it
configurable per-channel. This also gives us the time to get the
dmaengine API extensions worked out with Dan.
prev parent reply other threads:[~2010-03-02 3:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 16:29 [PATCH 0/2] Implement DMA support for the sh-sci.c serial driver Guennadi Liakhovetski
2010-02-18 16:30 ` [PATCH 1/2] sh: extend .device_terminate_all() to record partial transfer Guennadi Liakhovetski
2010-02-18 18:08 ` Paul Mundt
2010-02-18 16:30 ` [PATCH 2/2] Add DMA support for the sh-sci.c serial driver Guennadi Liakhovetski
2010-02-19 9:47 ` Govindraj
2010-02-19 9:56 ` Guennadi Liakhovetski
2010-02-19 10:12 ` Govindraj
2010-02-18 19:39 ` [PATCH/not-for-mainline] sh7722: enable DMA on all SCIF ports Guennadi Liakhovetski
2010-03-02 3:13 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302031310.GC20256@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=damm@opensource.se \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).