From: "Frédéric Brière" <fbriere@fbriere.net>
To: linux-kernel@vger.kernel.org
Cc: linux-serial@vger.kernel.org, linux-parport@lists.infradead.org
Subject: Re: [PATCH] parport/serial: add support for Timedia/SUNIX cards to parport_serial
Date: Mon, 12 Jul 2010 11:44:48 -0400 [thread overview]
Message-ID: <20100712154448.GA2558@toroia.fbriere.dyndns.org> (raw)
In-Reply-To: <20100708121122.17d3e823@lxorguk.ukuu.org.uk>
On Thu, Jul 08, 2010 at 12:11:22PM +0100, Alan Cox wrote:
> If you did that check in the serial driver and returned -ENODEV to the
> probe the id will be handed on to the next driver that matches (ie
> parport_serial)
Thanks for the suggestion; it does look much cleaner that way.
Instead of sticking a big-ass if() in the function, I took the liberty
of adding a .probe alongside the .init/.setup quirks, in case this could
be useful for other devices.
Note that I did not bother to cache the result of find_quirk(), so it
will be called twice. I did not find it worth to add extra complexity
just for that; let me know if you disagree.
--
On the Internet, no one knows you're using Windows NT
-- Submitted by Ramiro Estrugo, restrugo@fateware.com
next prev parent reply other threads:[~2010-07-12 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1277511823-6973-1-git-send-email-fbriere@fbriere.net>
2010-07-08 11:11 ` [PATCH] parport/serial: add support for Timedia/SUNIX cards to parport_serial Alan Cox
2010-07-12 15:44 ` Frédéric Brière [this message]
2010-07-12 15:49 ` [PATCH 1/2] serial: 8250_pci: add .probe member to struct pci_serial_quirk Frédéric Brière
2010-07-12 15:49 ` [PATCH 2/2] parport/serial: add support for Timedia/SUNIX cards to parport_serial Frédéric Brière
2010-07-12 16:56 ` [PATCH] " Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712154448.GA2558@toroia.fbriere.dyndns.org \
--to=fbriere@fbriere.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).