From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?B?RnLpZOlyaWMgQnJp6HJl?= Subject: Re: [PATCH] parport/serial: add support for Timedia/SUNIX cards to parport_serial Date: Mon, 12 Jul 2010 11:44:48 -0400 Message-ID: <20100712154448.GA2558@toroia.fbriere.dyndns.org> References: <1277511823-6973-1-git-send-email-fbriere@fbriere.net> <20100708121122.17d3e823@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mxout-07.mxes.net ([216.86.168.182]:34814 "EHLO mxout-07.mxes.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613Ab0GLPov (ORCPT ); Mon, 12 Jul 2010 11:44:51 -0400 Content-Disposition: inline In-Reply-To: <20100708121122.17d3e823@lxorguk.ukuu.org.uk> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: linux-serial@vger.kernel.org, linux-parport@lists.infradead.org On Thu, Jul 08, 2010 at 12:11:22PM +0100, Alan Cox wrote: > If you did that check in the serial driver and returned -ENODEV to the > probe the id will be handed on to the next driver that matches (ie > parport_serial) Thanks for the suggestion; it does look much cleaner that way. Instead of sticking a big-ass if() in the function, I took the liberty of adding a .probe alongside the .init/.setup quirks, in case this could be useful for other devices. Note that I did not bother to cache the result of find_quirk(), so it will be called twice. I did not find it worth to add extra complexity just for that; let me know if you disagree. -- On the Internet, no one knows you're using Windows NT -- Submitted by Ramiro Estrugo, restrugo@fateware.com