linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Yong Wang <yong.y.wang@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	Manuel Lauss <manuel.lauss@googlemail.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Masayuki Ohtake <masa-korg@dsn.okisemi.com>,
	"Khor, Andrew Chih Howe" <andrew.chih.howe.khor@intel.com>
Subject: Re: One question about 8250 UART driver
Date: Tue, 17 Aug 2010 09:16:22 +0100	[thread overview]
Message-ID: <20100817091622.5aa3dcf2@linux.intel.com> (raw)
In-Reply-To: <20100817013734.GA28407@ywang-moblin2.bj.intel.com>

On Tue, 17 Aug 2010 09:37:34 +0800
Yong Wang <yong.y.wang@linux.intel.com> wrote:

> Hi all,
> 
> We have a PCI based UART controller that is compatible with the
> existing 8250 serial driver in most aspects. However, one exception
> is that our UART controller can take advantage of the onboard DMA
> contoller to achieve higher throughput. Could you please share your
> insights about what is the proper way to add such DMA support into
> existing 8250 driver?

I'd say the same as I said to the other folks who asked this - create a
new driver. All the DMA based 8250 devices have differing DMA engines
and it'll become unmanagable in the existing driver.

Once we can see which bits of the existing code are useful for the DMA
8250-style devices we can then create an 8250-lib.c which contains the
bits that are useful to 8250 and to non standard 8250-like devices.

Alan

  reply	other threads:[~2010-08-17  8:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17  1:37 One question about 8250 UART driver Yong Wang
2010-08-17  8:16 ` Alan Cox [this message]
2010-08-17 13:24   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100817091622.5aa3dcf2@linux.intel.com \
    --to=alan@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew.chih.howe.khor@intel.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=manuel.lauss@googlemail.com \
    --cc=masa-korg@dsn.okisemi.com \
    --cc=ralf@linux-mips.org \
    --cc=yong.y.wang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).