From: Alan Cox <alan@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
greg@kroah.com, drosenberg@vsecurity.com
Subject: Re: [PATCH 0/3] Fix the TIOCGICOUNT problem for good
Date: Mon, 20 Sep 2010 09:31:07 +0100 [thread overview]
Message-ID: <20100920093107.379c431c@linux.intel.com> (raw)
In-Reply-To: <20100918155820.GA3942@infradead.org>
On Sat, 18 Sep 2010 11:58:20 -0400
Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Sep 16, 2010 at 06:21:06PM +0100, Alan Cox wrote:
> > Remembering to clear fields is something driver authors are simply
> > never going to remember to get right every new driver. Instead take
> > the problem away from them and give them a simple interface to do
> > the job.
>
> Btw, I wonder if all the standard tty ioctls should get similar
> treatment. That way we have a nice enough skeleton of what needs to
> be implemented in every tty driver instead of passing down the raw
> ioctl method.
They have pretty much entirely now - TIOCMIWAIT is the main one that
hasn't been done, but that really wants a generic implementation in
tty_port that most drivers could then use.
Alan
prev parent reply other threads:[~2010-09-20 9:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 17:21 [PATCH 0/3] Fix the TIOCGICOUNT problem for good Alan Cox
2010-09-16 17:21 ` [PATCH 1/3] tty: Make tiocgicount a handler Alan Cox
2010-09-16 17:21 ` [PATCH 2/3] tty: Convert the USB drivers to the new icount interface Alan Cox
2010-09-16 17:21 ` [PATCH 3/3] tty: icount changeover for other main devices Alan Cox
2010-09-16 18:44 ` [PATCH 0/3] Fix the TIOCGICOUNT problem for good Greg KH
2010-09-16 22:01 ` Alan Cox
2010-09-17 4:56 ` David Miller
2010-09-17 17:01 ` Greg KH
2010-09-18 15:58 ` Christoph Hellwig
2010-09-20 8:31 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920093107.379c431c@linux.intel.com \
--to=alan@linux.intel.com \
--cc=drosenberg@vsecurity.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).