From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tobias Klauser <tklauser@distanz.ch>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] serial: Factor out uart_poll_timeout() from 8250 driver
Date: Tue, 28 Sep 2010 15:04:33 +0100 [thread overview]
Message-ID: <20100928150433.76cc8178@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20100928133511.GA8289@oksana.dev.rtsoft.ru>
> +/* Base timer interval for polling */
> +int uart_poll_timeout(struct uart_port *port)
> +{
> + int timeout = port->timeout;
> +
> + return timeout > 6 ? (timeout / 2 - 2) : 1;
> +}
> +EXPORT_SYMBOL(uart_poll_timeout);
inline this rather than exporting it and making it global - it's a tiny
spec of code and the export symbol probably costs more !
prev parent reply other threads:[~2010-09-28 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 13:35 [PATCH 1/5] serial: Factor out uart_poll_timeout() from 8250 driver Anton Vorontsov
2010-09-28 14:04 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928150433.76cc8178@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=cbouatmailru@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox