From: Daniel Drake <dsd@laptop.org>
To: akpm@linux-foundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] serial8250: ratelimit "too much work" error
Date: Sat, 2 Oct 2010 12:04:38 +0100 (BST) [thread overview]
Message-ID: <20101002110438.801F49D401B@zog.reactivated.net> (raw)
Running a serial console, if too many kernel messages are generated within
a short time causing a lot of serial I/O, the 8250 driver will generate
another kernel message reporting this, which just adds to the I/O. It has
a cascading effect and quickly results the system being brought to its knees
by a flood of "too much work" messages.
Ratelimit the error message to avoid this.
Signed-off-by: Daniel Drake <dsd@laptop.org>
---
drivers/serial/8250.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 24110f6..d3c5855 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -1606,8 +1606,9 @@ static irqreturn_t serial8250_interrupt(int irq, void *dev_id)
if (l == i->head && pass_counter++ > PASS_LIMIT) {
/* If we hit this, we're dead. */
- printk(KERN_ERR "serial8250: too much work for "
- "irq%d\n", irq);
+ if (printk_ratelimit())
+ printk(KERN_ERR "serial8250: too much work for "
+ "irq%d\n", irq);
break;
}
} while (l != end);
--
1.7.2.3
next reply other threads:[~2010-10-02 11:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 11:04 Daniel Drake [this message]
2010-10-02 14:22 ` [PATCH] serial8250: ratelimit "too much work" error Alan Cox
2010-10-04 21:51 ` Andrew Morton
2010-10-04 22:02 ` Andrew Morton
2010-10-04 22:10 ` Joe Perches
2010-10-04 22:21 ` Andrew Morton
2010-10-04 22:59 ` Joe Perches
2010-10-04 23:11 ` Andrew Morton
2010-10-04 23:34 ` Joe Perches
2010-10-04 23:49 ` Andrew Morton
2010-10-05 0:26 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101002110438.801F49D401B@zog.reactivated.net \
--to=dsd@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox