From: Tobias Klauser <tklauser@distanz.ch>
To: Thomas Chou <thomas@wytron.com.tw>
Cc: Grant Likely <grant.likely@secretlab.ca>,
nios2-dev@sopc.et.ntust.edu.tw, Greg KH <greg@kroah.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-serial@vger.kernel.org
Subject: Re: [Nios2-dev] [PATCH 0/5] tty: serial: Updates for altera_jtaguart driver
Date: Fri, 18 Feb 2011 08:45:42 +0100 [thread overview]
Message-ID: <20110218074542.GA759@distanz.ch> (raw)
In-Reply-To: <4D5E1FF6.20805@wytron.com.tw>
On 2011-02-18 at 08:29:58 +0100, Thomas Chou <thomas@wytron.com.tw> wrote:
> On 02/18/2011 03:23 PM, Tobias Klauser wrote:
>> On 2011-02-17 at 23:15:04 +0100, Greg KH<greg@kroah.com> wrote:
>>> On Thu, Feb 17, 2011 at 09:28:23PM +0100, Tobias Klauser wrote:
>>>> This patchset adds updates taken from the Nios2 Linux port (currently
>>>> out-of-tree) repository to the altera_jtaguart driver.
>>>>
>>>> And this time with the correct cover letter right away :-)
>>>>
>>>> Tobias Klauser (5):
>>>> tty: serial: altera_jtaguart: Don't use plain integer as NULL pointer
>>>> tty: serial: altera_jtaguart: Remove unused function
>>>> early_altera_jtaguart_setup
>>>> tty: serial: altera_jtaguart: Support getting mapbase and IRQ from
>>>> resources
>>>> tty: serial: altera_jtaguart: Fixup type usage of port flags
>>>> tty: serial: altera_jtaguart: Add device tree support
>>>
>>> After this series, I get the following build error:
>>> CC [M] drivers/tty/serial/altera_jtaguart.o
>>> drivers/tty/serial/altera_jtaguart.c:485:3: error: unknown field ???of_match_table??? specified in initializer
>>
>> Strange, I didn't get that one when compile testing against linux-next
>> on x86_64. Though it seems I didn't correctly test it on nios2 and I got
>> a compile error about a missing semicolon in the definition of
>> altera_jtaguart_match there.
>
> It might be that the of_match_table patch is available in Grant's branch
> only, which is for v3.6.39. Maybe you can ask Grant to take this patch
> 5/5.
That explains it, thanks Thomas.
Greg, care to take only patches 1/5 to 4/5 for now? I'll resubmit 5/5
for the 2.6.39 merge window, unless Grant already wants to take this to
his tree.
next prev parent reply other threads:[~2011-02-18 7:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 20:28 [PATCH 0/5] tty: serial: Updates for altera_jtaguart driver Tobias Klauser
2011-02-17 20:28 ` [PATCH 1/5] tty: serial: altera_jtaguart: Don't use plain integer as NULL pointer Tobias Klauser
2011-02-17 20:29 ` [PATCH 2/5] tty: serial: altera_jtaguart: Remove unused function early_altera_jtaguart_setup Tobias Klauser
2011-02-17 20:29 ` [PATCH 3/5] tty: serial: altera_jtaguart: Support getting mapbase and IRQ from resources Tobias Klauser
2011-02-17 20:29 ` [PATCH 4/5] tty: serial: altera_jtaguart: Fixup type usage of port flags Tobias Klauser
2011-02-17 20:30 ` [PATCH 5/5] tty: serial: altera_jtaguart: Add device tree support Tobias Klauser
2011-02-18 7:54 ` [PATCH 5/5 v2] " Tobias Klauser
2011-02-18 7:59 ` Grant Likely
[not found] ` <c28550ba11ed228f4137ced1ab34761c08ad38ad.1297974227.git.tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
2011-02-18 8:10 ` [PATCH 5/5 v3] " Tobias Klauser
2011-02-28 8:26 ` Grant Likely
2011-02-17 22:15 ` [PATCH 0/5] tty: serial: Updates for altera_jtaguart driver Greg KH
2011-02-18 7:23 ` Tobias Klauser
2011-02-18 7:29 ` [Nios2-dev] " Thomas Chou
2011-02-18 7:45 ` Tobias Klauser [this message]
2011-02-18 8:06 ` Grant Likely
2011-02-18 8:11 ` Tobias Klauser
2011-02-18 17:20 ` Grant Likely
2011-02-18 15:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110218074542.GA759@distanz.ch \
--to=tklauser@distanz.ch \
--cc=grant.likely@secretlab.ca \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-serial@vger.kernel.org \
--cc=nios2-dev@sopc.et.ntust.edu.tw \
--cc=thomas@wytron.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).