From: Grant Likely <grant.likely@secretlab.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Daney <ddaney@caviumnetworks.com>,
linux-serial@vger.kernel.org, gregkh@suse.de,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [RFC PATCH 1/2] serial: 8250: Add a notifier chain for driver registration.
Date: Thu, 17 Mar 2011 12:25:10 -0600 [thread overview]
Message-ID: <20110317182510.GN9597@angua.secretlab.ca> (raw)
In-Reply-To: <20110317121849.49d7c425@lxorguk.ukuu.org.uk>
On Thu, Mar 17, 2011 at 12:18:49PM +0000, Alan Cox wrote:
> On Wed, 16 Mar 2011 18:26:06 -0700
> David Daney <ddaney@caviumnetworks.com> wrote:
>
> > The 8250 driver is a bit weird in that in addition to supporting
> > platform devices, extra devices can be added by calling
> > serial8250_register_port().
> >
> > The problem is that if we call serial8250_register_port() before the
> > driver is initialized Bad Things happen (we dereference NULL
> > pointers).
> >
> > There doesn't seem to be a general way to know if a driver has been
> > initialized
>
> I've had a bigger dig into this. I think the correct answer is probably
> "always go via platform devices or similar". That *is* the notifier in
> the kernel of today. serial8250_register_port ultimately should I think
> ultimatly become an internal helper.
+1
Depending on serial8250_register_port() definitely the wrong thing to
do for platform support code. It would be better to figure out how to
get the dt bits you need into 8250.c or of_serial.c.
g.
next prev parent reply other threads:[~2011-03-17 18:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 1:26 [RFC PATCH 0/2] serial: Hack up 8520.c for evil device tree hookin David Daney
[not found] ` <1300325167-26433-1-git-send-email-ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2011-03-17 1:26 ` [RFC PATCH 1/2] serial: 8250: Add a notifier chain for driver registration David Daney
[not found] ` <1300325167-26433-2-git-send-email-ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2011-03-17 12:18 ` Alan Cox
2011-03-17 16:42 ` David Daney
2011-03-17 18:25 ` Grant Likely [this message]
[not found] ` <20110317182510.GN9597-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2011-03-17 18:42 ` David Daney
2011-03-17 18:47 ` Grant Likely
[not found] ` <20110317184723.GQ9597-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2011-03-17 19:24 ` Alan Cox
2011-03-17 19:31 ` Grant Likely
[not found] ` <20110317193149.GD12824-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2011-03-17 20:13 ` David Daney
2011-03-17 20:31 ` Grant Likely
2011-03-17 23:48 ` Alan Cox
2011-03-18 5:18 ` Grant Likely
2011-03-17 1:26 ` [RFC PATCH 2/2] MIPS: Octeon: Use device tree to register serial ports David Daney
2011-03-17 18:28 ` Grant Likely
2011-03-17 18:35 ` David Daney
2011-03-17 1:46 ` [RFC PATCH 0/2] serial: Hack up 8520.c for evil device tree hookin Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317182510.GN9597@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ddaney@caviumnetworks.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).