From mboxrd@z Thu Jan  1 00:00:00 1970
From: Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [RFC PATCH 1/2] serial: 8250: Add a notifier chain for driver
 registration.
Date: Thu, 17 Mar 2011 13:31:49 -0600
Message-ID: <20110317193149.GD12824@angua.secretlab.ca>
References: <1300325167-26433-1-git-send-email-ddaney@caviumnetworks.com>
 <1300325167-26433-2-git-send-email-ddaney@caviumnetworks.com>
 <20110317121849.49d7c425@lxorguk.ukuu.org.uk>
 <20110317182510.GN9597@angua.secretlab.ca>
 <4D82560B.4090800@caviumnetworks.com>
 <20110317184723.GQ9597@angua.secretlab.ca>
 <20110317192441.69c699b1@lxorguk.ukuu.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-serial-owner@vger.kernel.org>
Received: from mail-iw0-f174.google.com ([209.85.214.174]:62824 "EHLO
	mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752718Ab1CQTbw (ORCPT
	<rfc822;linux-serial@vger.kernel.org>);
	Thu, 17 Mar 2011 15:31:52 -0400
Content-Disposition: inline
In-Reply-To: <20110317192441.69c699b1@lxorguk.ukuu.org.uk>
Sender: linux-serial-owner@vger.kernel.org
List-Id: linux-serial@vger.kernel.org
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Daney <ddaney@caviumnetworks.com>, linux-serial@vger.kernel.org, gregkh@suse.de, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org

On Thu, Mar 17, 2011 at 07:24:41PM +0000, Alan Cox wrote:
> > > If we did that, serial8250_probe() would automatically do the right thing.
> > 
> > Take a look at the way arch/powerpc/platforms/512x/pdm360ng.c uses a
> > notifier for amending a platform_device with additional data..
> 
> I tend to view arch specific embedded code as rather like very dubious
> parties. What goes on in other peoples' house out of sight is none of my
> business.
> 
> The 8250 however is core code so it should keep its clothers on and behave
> in a manner befitting its status.
> 
> What part of the problem can't be solved by doing it properly using the
> device registration interfaces we have today ?

Device registration isn't the problem.  The problem is supplying
machine-specific callbacks from the board support code to the
drivers.  When devices are sourced from a device tree, it is easy to
get data about the device out of the tree, but it is really hard to
get callback pointers.  To make it all work without this fiddling
about, the octeon serial_{in,out} implementation would need to be
rolled into of_serial.c (which FWIW, I have absolutely no problem
with).

g.