From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: John Linn <John.Linn@xilinx.com>
Cc: michal.simek@petalogix.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, greg@kroah.com,
grant.likely@secretlab.ca
Subject: Re: [PATCH V2] tty/serial: add support for Xilinx PS UART
Date: Fri, 22 Apr 2011 17:23:52 +0100 [thread overview]
Message-ID: <20110422172352.308455ce@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <ad920746-773d-475a-9c0e-dc5dd7a4b1e1@VA3EHSMHS026.ehs.local>
> I don't have a problem removing the empty lines, but is there some
> guideline on that
> which I'm ignoring and should know?
Not in general - mostly its people inventing style. There's a lot to be
said for consistency in spacing but quite frankly people worrying about it
could spend their time more usefully on fixing actual bugs and really
ugly code of which the kernel still has a plentiful supply.
Alan
next prev parent reply other threads:[~2011-04-22 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 19:03 [PATCH V2] tty/serial: add support for Xilinx PS UART John Linn
2011-04-22 9:11 ` Michal Simek
2011-04-22 9:20 ` Joe Perches
2011-04-22 13:40 ` John Linn
2011-04-22 13:36 ` John Linn
2011-04-22 16:23 ` Alan Cox [this message]
2011-04-22 15:12 ` John Linn
2011-04-22 15:22 ` Greg KH
2011-04-22 15:25 ` John Linn
2011-04-22 15:40 ` Grant Likely
2011-04-22 15:46 ` Grant Likely
2011-04-22 15:55 ` John Linn
2011-04-22 15:47 ` John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110422172352.308455ce@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=John.Linn@xilinx.com \
--cc=grant.likely@secretlab.ca \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@petalogix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox