From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: johnlinn@comcast.net
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
michal.simek@petalogix.com, joe@perches.com,
grant.likely@secretlab.ca, greg@kroah.com
Subject: Re: [PATCH V3] tty/serial: add support for Xilinx PS UART
Date: Wed, 27 Apr 2011 10:33:40 +0100 [thread overview]
Message-ID: <20110427103340.2554df83@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <549692800.1907368.1303859758362.JavaMail.root@sz0140a.emeryville.ca.mail.comcast.net>
> I thought I was improving but now as I look at it further, that seems like it
> was better and I should have stuck to that method.
>
> Thoughts?
Go for nearest is the right behaviour. The whole tty layer works on that
basis as do soem other things. It means you don't have to have a set of
calls to do things like "enumerate valid data rates" instead you ask and
compare.
> > > + uart_update_timeout(port, termios->c_cflag, baud);
> >
> > [which would also fix this timeout!]
>
> Maybe you were meaning that if the baud rate was not really set because of the
> error this timeout would be wrong also, and if so that makes sense.
Correct
Alan
next prev parent reply other threads:[~2011-04-27 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <381805170.1906645.1303859011392.JavaMail.root@sz0140a.emeryville.ca.mail.comcast.net>
2011-04-26 23:15 ` [PATCH V3] tty/serial: add support for Xilinx PS UART johnlinn
2011-04-27 9:33 ` Alan Cox [this message]
2011-04-27 13:21 ` johnlinn
2011-04-27 14:15 ` Alan Cox
[not found] <342576875.1870580.1303826202211.JavaMail.root@sz0140a.emeryville.ca.mail.comcast.net>
2011-04-26 14:18 ` johnlinn
2011-04-26 19:47 ` Greg KH
2011-04-26 21:19 ` johnlinn
2011-04-22 19:13 John Linn
2011-04-26 19:58 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427103340.2554df83@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=grant.likely@secretlab.ca \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=johnlinn@comcast.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@petalogix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox