linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Antony Pavlov <antony@niisi.msk.ru>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	Alan Cox <alan@linux.intel.com>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_pci: add support for Cronyx Omega PCI multiserial board.
Date: Fri, 13 May 2011 16:22:35 -0700	[thread overview]
Message-ID: <20110513232235.GA14997@kroah.com> (raw)
In-Reply-To: <1305316189-31027-1-git-send-email-antony@niisi.msk.ru>

On Fri, May 13, 2011 at 11:49:49PM +0400, Antony Pavlov wrote:
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -1028,6 +1028,7 @@
>  #define PCI_DEVICE_ID_PLX_9056		0x9056
>  #define PCI_DEVICE_ID_PLX_9080		0x9080
>  #define PCI_DEVICE_ID_PLX_GTEK_SERIAL2	0xa001
> +#define PCI_DEVICE_ID_PLX_CRONYX_OMEGA	0xc001

Please don't add new entries to this file, look at the top of it for
why.

Please move this into the driver file itself and resend this.

thanks,

greg k-h

  parent reply	other threads:[~2011-05-13 23:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13 19:49 [PATCH] serial: 8250_pci: add support for Cronyx Omega PCI multiserial board Antony Pavlov
2011-05-13 21:01 ` Alan Cox
2011-05-13 23:22 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-05-14  4:39 Antony Pavlov
2011-05-17 18:22 ` Greg KH
2011-05-18 18:38 Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110513232235.GA14997@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@linux.intel.com \
    --cc=antony@niisi.msk.ru \
    --cc=gregkh@suse.de \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).