From: Shreshtha Kumar SAHU <shreshthakumar.sahu@stericsson.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Linus WALLEIJ <linus.walleij@stericsson.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 2/2] amba pl011: platform data for reg lockup and glitch
Date: Fri, 10 Jun 2011 14:37:06 +0530 [thread overview]
Message-ID: <20110610090704.GA476@bnru02.bnr.st.com> (raw)
In-Reply-To: <20110609210218.GH24424@n2100.arm.linux.org.uk>
On Thu, Jun 09, 2011 at 23:02:18 +0200, Russell King - ARM Linux wrote:
> On Thu, Jun 09, 2011 at 10:56:48PM +0200, Linus Walleij wrote:
> > + /* uart-0 pins gpio configuration should be
> > + * kept intact to prevent glitch in tx line
> > + * when tty dev is opened. Later these pins
> > + * are configured to uart mop500_pins_uart0
> > + *
> > + * It will be replaced with uart configuration
> > + * once the issue is solved.
> > + */
> > + GPIO0_GPIO | PIN_INPUT_PULLUP,
> > + GPIO1_GPIO | PIN_OUTPUT_HIGH,
> > + GPIO2_GPIO | PIN_INPUT_PULLUP,
> > + GPIO3_GPIO | PIN_OUTPUT_LOW,
>
> Why do you want the TXD line (GPIO3) to be indicating a break condition?
Yes it should be PIN_OUTPUT_HIGH, as it is configured in mop500_pins_uart0.
Thanks,
Shreshtha
next prev parent reply other threads:[~2011-06-10 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 20:56 [PATCH 2/2] amba pl011: platform data for reg lockup and glitch Linus Walleij
2011-06-09 21:02 ` Russell King - ARM Linux
2011-06-10 9:07 ` Shreshtha Kumar SAHU [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-16 13:01 [PATCH 1/2] amba pl011: workaround for uart registers lockup Shreshtha Kumar SAHU
2011-05-16 13:01 ` [PATCH 2/2] amba pl011: platform data for reg lockup and glitch Shreshtha Kumar SAHU
2011-05-16 13:09 ` Russell King
2011-05-16 14:00 ` Shreshtha Kumar SAHU
2011-05-16 14:05 ` Russell King
2011-05-16 14:15 ` Shreshtha Kumar SAHU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110610090704.GA476@bnru02.bnr.st.com \
--to=shreshthakumar.sahu@stericsson.com \
--cc=gregkh@suse.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).