[PATCH] n_gsm: fix the wrong FCS handling

[PATCH] n_gsm: fix the wrong FCS handling

[Alan Cox]

From: \"Du, Alek\" <alek.du@intel.com>

FCS could be GSM0_SOF, so will break state machine...

[This byte isn't quoted in any way so a SOF here doesn't imply an error
 occurred.]

Signed-off-by: Alek Du <alek.du@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>

[Trivial but best backported once its in 3.1rc I think]
---

 drivers/tty/n_gsm.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index ec37f57..8a50e4e 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1885,10 +1885,6 @@ static void gsm0_receive(struct gsm_mux *gsm, unsigned char c)
 		break;
 	case GSM_FCS:		/* FCS follows the packet */
 		gsm->received_fcs = c;
-		if (c == GSM0_SOF) {
-			gsm->state = GSM_SEARCH;
-			break;
-		}
 		gsm_queue(gsm);
 		gsm->state = GSM_SSOF;
 		break;

Re: [PATCH] n_gsm: fix the wrong FCS handling

[Greg KH]

On Thu, Jul 07, 2011 at 03:16:48PM +0100, Alan Cox wrote:
> From: \"Du, Alek\" <alek.du@intel.com>

I don't think git would like those \ characters, would it?

> FCS could be GSM0_SOF, so will break state machine...
> 
> [This byte isn't quoted in any way so a SOF here doesn't imply an error
>  occurred.]
> 
> Signed-off-by: Alek Du <alek.du@intel.com>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> 
> [Trivial but best backported once its in 3.1rc I think]

So should I mark it for stable for 3.0?

thanks,

greg k-h