Re: [RFC v2]: Issues implementing clock handling mechanism within UART driver

Felipe Balbi
2011-07-29T09:55:13Z

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

Hi,

On Thu, Jul 28, 2011 at 02:59:55PM +0530, Govindraj.R wrote:
> Proposal:
> --------
> 1. For the UART, follow the current approach of locking the console in
> Idle/Suspend path before cutting the clock but using pm_runtime_putsync.
> That is, continue using the prepare/resume Idle calls in idle path.

I believe you should be using ->prepare() to prevent that any other
work on UART won't trigger a console_write() right now. Maybe only
queueing the work for after ->complete() or, maybe, just ignoring the
work and loosing some prints, dunno.

> 2. Other Approach would be adding conditions to debug prints from
> omap_device/ omap_hwmod/clock_framework avoid calling these debug
> prints for uart.
> Or Even a debug macro that would not debug prints if the context is
> from uart.

yeah, that might work but then again, if we were using 8250.c, would we
have this limitation ??

I think that, maybe, your best call would be to capture console_write()
calls into an internal temporary buffer on ->prepare() and flush it once
->complete() is called ?

BTW, where are the patches ? :-)

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]