Re: [PATCH 0/5] Remove UPIO_DWAPB{,32} from 8250 driver

[Jamie Iles <jamie@jamieiles.com>]

On Tue, Aug 16, 2011 at 04:05:08PM +0200, Arnd Bergmann wrote:
> On Monday 15 August 2011, Jamie Iles wrote:
> > 
> > This is just a repost of a series from a couple of months ago to remove
> > the special DWAPB 8250 handling from the generic driver.
> > 
> > Arnd, I'd have a platform that needs some special handlers like these
> > using the device tree and of_serial.  Once these are merged I plan on
> > passing the serial_{in,out} and handle_irq callbacks through
> > platform_data to of_serial.  Does this seem sensible?
> 
> Do you mean passing through the uart_port? Yes, that seems sensible.
> Depending on how complicated the callbacks are, it might be
> simpler to write a new platform_driver based on of_serial.c for
> your device that hardcodes these.

Well for my platform it's handling the DesignWare variant of the 8250 
but the bus restricts us to 32-bit accesses.

> The of_serial driver started out with the goal of covering all sorts
> of serial port devices based on device tree probing, but with the
> direction that the platform drivers have moved to, this seems a bit
> silly, and I think we should take the NWPSERIAL support out and
> rename it to 8250_of.c.

In that case I could add an ns8250dw compatible string and put the 
handlers into here (both 8 and 32 bit variants).  Note that the MIPS 
user that I've removed in this series should probably still keep the 
accessors in the platform code as they've remapped the USR to a 
different location to the Synopsys spec.

Jamie