From: Arnd Bergmann <arnd@arndb.de>
To: Jamie Iles <jamie@jamieiles.com>
Cc: linux-serial@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 1/2] tty: serial8250: add helpers for the DesignWare 8250
Date: Tue, 16 Aug 2011 18:57:58 +0200 [thread overview]
Message-ID: <201108161857.58613.arnd@arndb.de> (raw)
In-Reply-To: <1313513267-25955-2-git-send-email-jamie@jamieiles.com>
On Tuesday 16 August 2011, Jamie Iles wrote:
> The Synopsys DesignWare 8250 is an 8250 that has an extra interrupt that
> gets raised when writing to the LCR when busy. To handle this we need
> special serial_out, serial_in and handle_irq methods. Add a new
> function serial8250_use_designware_io() that configures a uart_port with
> these accessors.
>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Hmm, this looks about as good as the solution that I had in mind (doing
a new platform_driver). I can't any obvious advantages either way, so
I guess you get to have your version ;-)
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2011-08-16 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 16:47 [PATCH 0/2] serial8250: support for DesignWare 8250 Jamie Iles
2011-08-16 16:47 ` [PATCH 1/2] tty: serial8250: add helpers for the " Jamie Iles
2011-08-16 16:57 ` Arnd Bergmann [this message]
2011-08-16 16:47 ` [PATCH 2/2] tty: of_serial: add support " Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108161857.58613.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=jamie@jamieiles.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox