From: Alan Cox <alan@linux.intel.com>
To: Hui Wang <jason77.wang@gmail.com>
Cc: gregkh@suse.de, s.hauer@pengutronix.de, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial/imx: support to handle break character
Date: Wed, 24 Aug 2011 16:50:48 +0100 [thread overview]
Message-ID: <20110824165048.07721783@bob.linux.org.uk> (raw)
In-Reply-To: <1314178907-20074-1-git-send-email-jason77.wang@gmail.com>
On Wed, 24 Aug 2011 17:41:47 +0800
Hui Wang <jason77.wang@gmail.com> wrote:
> The imx UART hardware controller can identify BREAK character and the
> imx_set_termios() can accept BRKINT set by users, but current existing
> imx_rxint() can't pass BREAK character and TTY_BREAK to the tty layer
> as other serial drivers do (8250.c omap_serial.c).
>
> Here add code to handle BREAK character and pass it to tty layer.
>
> To detect error occurrence, i use URXD_ERR to replace (URXD_OVRRUN |
> URXD_FRMERR | ...) because any kind of error occurs, URXD_ERR will
> always be set to 1.
>
> I put the URXD_BRK to the first place to check since when BREAK error
> occurs, not only URXD_BRK is set to 1, but also URXD_PRERR and
> URXD_FRMERR are all set to 1. This arrangement can filter out fake
> parity and frame errors when BREAK error occurs.
>
> Signed-off-by: Hui Wang <jason77.wang@gmail.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2011-08-24 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 9:41 [PATCH] serial/imx: support to handle break character Hui Wang
2011-08-24 15:49 ` Sascha Hauer
2011-08-24 15:50 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824165048.07721783@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=jason77.wang@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).