From: Arnd Bergmann <arnd@arndb.de>
To: Jamie Iles <jamie@jamieiles.com>
Cc: linux-serial@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] tty: 8250_dw: fix build error for CONFIG_SERIAL_8250=m
Date: Wed, 24 Aug 2011 18:14:04 +0200 [thread overview]
Message-ID: <201108241814.04695.arnd@arndb.de> (raw)
In-Reply-To: <20110824152434.GQ23757@pulham.picochip.com>
On Wednesday 24 August 2011, Jamie Iles wrote:
> On Wed, Aug 24, 2011 at 04:45:16PM +0200, Arnd Bergmann wrote:
> > When go go to such length, I think the approach I initially advocated
> > (making 8250_dw a standalone platform_driver like of_serial) will be
> > nicer.
>
> For a separate driver, is it okay to make it depend on CONFIG_OF, and
> only have device tree bindings, or should this still support being
> registered as a static platform device with platform data? I'm not sure
> what the consensus is on creating device tree only platform drivers.
Do only what is necessary. If the devices are all probed using device
tree, then support only that. If someone else really needs static
platform_data instead, they can add support for that later.
Arnd
prev parent reply other threads:[~2011-08-24 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 7:11 [PATCH] tty: 8250_dw: fix build error for CONFIG_SERIAL_8250=m Jamie Iles
2011-08-24 14:45 ` Arnd Bergmann
2011-08-24 14:54 ` Jamie Iles
2011-08-24 15:09 ` Greg KH
2011-08-24 15:12 ` Jamie Iles
2011-08-24 15:24 ` Jamie Iles
2011-08-24 16:14 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108241814.04695.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=jamie@jamieiles.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox