From: "Søren holm" <sgh@sgh.dk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-serial@vger.kernel.org
Subject: Re: Hardware flowcontrol on XR17D154
Date: Tue, 30 Aug 2011 15:14:13 +0200 [thread overview]
Message-ID: <201108301514.13268.sgh@sgh.dk> (raw)
In-Reply-To: <20110830133221.304b27f0@lxorguk.ukuu.org.uk>
> > My particular uart resports (status1 == 6 && status2 == 6). If that is
> > good enough I can add another porttype and add the correct register
> > address as UART_EXAR_EFR in the header file.
>
> Try it and see. We can put it in -next for a while and then there will a
> release cycle duriing which any unfortunate clashes wil get resolved.
I will prepare and test a patch.
> Alternatively if it's a device attached to a specific platform create it
> as a platform device of some kind in the board specific code and pick
> that up in the serial driver.
>
> > Another thought could be to write 0xFF (or some other value) to the
> > correct EFR-register and read that byte to test if the register is
> > present. The problem here is that I do not how the bus reacts to
> > writting/reading invalid addresses.
>
> The trouble is an extra register may in fact be part of some other device
> - it's generally not a great idea if there are other choices.
Ok. It did seem like a dangerous thing to do.
Thanks Alan
--
Søren Holm
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-30 13:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 10:17 Hardware flowcontrol on XR17D154 Søren holm
2011-08-30 10:34 ` Alan Cox
2011-08-30 11:27 ` Søren holm
2011-08-30 12:32 ` Alan Cox
2011-08-30 13:14 ` Søren holm [this message]
2011-09-02 10:20 ` Søren holm
2011-09-02 12:28 ` Alan Cox
2011-09-02 20:52 ` [PATCH] serial: Support the EFR-register of XR1715x uarts Søren Holm
2011-09-02 20:55 ` Søren Holm
2011-09-03 10:47 ` Alan Cox
2011-09-02 21:11 ` Hardware flowcontrol on XR17D154 Søren holm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108301514.13268.sgh@sgh.dk \
--to=sgh@sgh.dk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox