From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: WANG Cong <xiyou.wangcong@gmail.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Alan Cox <alan@linux.intel.com>,
linux-cris-kernel@axis.com, linux-serial@vger.kernel.org
Subject: Re: [PATCH] cris: lower the printk level in cris serial driver
Date: Thu, 1 Sep 2011 09:09:30 +0100 [thread overview]
Message-ID: <20110901090930.064c2775@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <CAMuHMdWSm2bQQpdM1OM=6+17CeNikn9RYm_BpFmEV7jD4sAPig@mail.gmail.com>
> > if (info->recv_cnt + recvl > 65536) {
> > - printk(KERN_CRIT
> > + printk(KERN_INFO
> > "%s: Too much pending incoming serial data! Dropping %u bytes.\n", __func__, recvl);
> > return 0;
> > }
>
> I think dropped data warrants KERN_WARN.
If you have an overflow you want to push the relevant tty flag into the
queue. I'm not sure a printk is that useful - end users of embedded
devices (or even PC desktops) won't see it anyway and if you have serial
console it can actually make things worse
Plus of course it's not rate limited here so its a log wiping vector ...
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-09-01 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 6:14 [PATCH] cris: lower the printk level in cris serial driver WANG Cong
2011-09-01 6:35 ` Geert Uytterhoeven
2011-09-01 7:16 ` Américo Wang
2011-09-01 8:09 ` Alan Cox [this message]
2011-09-01 8:34 ` Mikael Starvik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901090930.064c2775@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=jesper.nilsson@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=starvik@axis.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox