* [PATCH] serial: SERIAL_MRST_MAX3110 should depend on X86_MRST
@ 2011-09-16 20:40 Jean Delvare
2011-09-17 11:28 ` Alan Cox
2011-09-27 11:01 ` Alan Cox
0 siblings, 2 replies; 4+ messages in thread
From: Jean Delvare @ 2011-09-16 20:40 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-serial
As I understand it, driver mrst_max3110 is only useful on Moorestown
systems, so it should depend on X86_MRST.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Alan Cox <alan@linux.intel.com>
---
There are a few other drivers in a similar situation
(i2c/busses/i2c-intel-mid, gpio/langwell_gpio, tty/serial/mfd,
staging/sep) for which I suspect the same should be done,
assuming that X86_MRST is for both Moorestown and Medfield.
drivers/tty/serial/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.1-rc4.orig/drivers/tty/serial/Kconfig 2011-08-16 11:49:57.000000000 +0200
+++ linux-3.1-rc4/drivers/tty/serial/Kconfig 2011-09-16 22:03:32.000000000 +0200
@@ -695,7 +695,7 @@ config SERIAL_SA1100_CONSOLE
config SERIAL_MRST_MAX3110
tristate "SPI UART driver for Max3110"
- depends on SPI_DW_PCI
+ depends on X86_MRST && SPI_DW_PCI
select SERIAL_CORE
select SERIAL_CORE_CONSOLE
help
--
Jean Delvare
Suse L3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: SERIAL_MRST_MAX3110 should depend on X86_MRST
2011-09-16 20:40 [PATCH] serial: SERIAL_MRST_MAX3110 should depend on X86_MRST Jean Delvare
@ 2011-09-17 11:28 ` Alan Cox
2011-09-27 11:01 ` Alan Cox
1 sibling, 0 replies; 4+ messages in thread
From: Alan Cox @ 2011-09-17 11:28 UTC (permalink / raw)
To: Jean Delvare; +Cc: Alan Cox, linux-serial
On Fri, 16 Sep 2011 22:40:16 +0200
Jean Delvare <jdelvare@suse.de> wrote:
> As I understand it, driver mrst_max3110 is only useful on Moorestown
> systems, so it should depend on X86_MRST.
Not so simple. There are various things that need dependancies. Some I've
sorted in my tree, some not, but it's all shelved until kernel.org is
back as I've switched to working on other projects for the moment rather
than waste time chasing trees around the internet.
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Alan Cox <alan@linux.intel.com>
> ---
> There are a few other drivers in a similar situation
> (i2c/busses/i2c-intel-mid, gpio/langwell_gpio, tty/serial/mfd,
> staging/sep) for which I suspect the same should be done,
> assuming that X86_MRST is for both Moorestown and Medfield.
Not with the latest patches.
Alan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: SERIAL_MRST_MAX3110 should depend on X86_MRST
2011-09-16 20:40 [PATCH] serial: SERIAL_MRST_MAX3110 should depend on X86_MRST Jean Delvare
2011-09-17 11:28 ` Alan Cox
@ 2011-09-27 11:01 ` Alan Cox
2011-09-27 12:10 ` Jean Delvare
1 sibling, 1 reply; 4+ messages in thread
From: Alan Cox @ 2011-09-27 11:01 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-serial
On Fri, 16 Sep 2011 22:40:16 +0200
Jean Delvare <jdelvare@suse.de> wrote:
> As I understand it, driver mrst_max3110 is only useful on Moorestown
> systems, so it should depend on X86_MRST.
Digging into this it builds fine on any X86 so it's more useful that it
is able to get build tested than to add extra config stuff making it
hard to catch bugs when changing the serial layer.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: SERIAL_MRST_MAX3110 should depend on X86_MRST
2011-09-27 11:01 ` Alan Cox
@ 2011-09-27 12:10 ` Jean Delvare
0 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2011-09-27 12:10 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-serial
On Tuesday 27 September 2011 01:01:15 pm Alan Cox wrote:
> On Fri, 16 Sep 2011 22:40:16 +0200
>
> Jean Delvare <jdelvare@suse.de> wrote:
> > As I understand it, driver mrst_max3110 is only useful on
> > Moorestown systems, so it should depend on X86_MRST.
>
> Digging into this it builds fine on any X86 so it's more useful that
> it is able to get build tested than to add extra config stuff making
> it hard to catch bugs when changing the serial layer.
OK, fair enough.
--
Jean Delvare
Suse L3
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-27 12:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-16 20:40 [PATCH] serial: SERIAL_MRST_MAX3110 should depend on X86_MRST Jean Delvare
2011-09-17 11:28 ` Alan Cox
2011-09-27 11:01 ` Alan Cox
2011-09-27 12:10 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).