From: Greg KH <greg@kroah.com>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: linux-serial@vger.kernel.org, gregkh@suse.de
Subject: Re: [PATCH: tty-next] TTY: serial: Move mutex_unlock in uart_close function
Date: Thu, 22 Sep 2011 15:43:30 -0700 [thread overview]
Message-ID: <20110922224330.GA21296@kroah.com> (raw)
In-Reply-To: <1314600216-8146-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
On Mon, Aug 29, 2011 at 03:43:36PM +0900, Nobuhiro Iwamatsu wrote:
> When mutex_lock is not called, mutex_unlock is sometimes called.
> This deletes unnecessary goto and makes modifications so that
> mutex_unlock is called.
No you don't, your patch prevents mutex_unlock() from being called:
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1262,7 +1262,7 @@ static void uart_close(struct tty_struct *tty, struct file *filp)
>
> if (tty_hung_up_p(filp)) {
> spin_unlock_irqrestore(&port->lock, flags);
> - goto done;
> + return;
Before this mutex_lock() was called, so we need to unlock it, yet you
just prevented that from happening.
So this patch is not correct at all, right?
greg k-h
next prev parent reply other threads:[~2011-09-22 23:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 6:43 [PATCH: tty-next] TTY: serial: Move mutex_unlock in uart_close function Nobuhiro Iwamatsu
2011-09-22 22:43 ` Greg KH [this message]
2011-09-22 22:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922224330.GA21296@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-serial@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox