From: Alan Cox <alan@linux.intel.com>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com>
Cc: linux-serial@vger.kernel.org, gregkh@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tty/n_gsm: fix a bug in gsm_dlci_data_output (adaption = 2 case)
Date: Tue, 27 Sep 2011 11:58:04 +0100 [thread overview]
Message-ID: <20110927115804.40ab56dc@bob.linux.org.uk> (raw)
In-Reply-To: <1316791376-4863-1-git-send-email-mikhail.kshevetskiy@gmail.com>
On Fri, 23 Sep 2011 19:22:55 +0400
Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com> wrote:
> in adaption=2 case we should put 1 or 2 byte with modem status bits
> at the beginning of a buffer pointed by "dp". n_gsm use 1 byte case,
> so it allocate a buffer of len + 1 size. As result we should:
> * put 1 byte of modem status bits
> * increase data pointer
> * put "len" bytes of data
> but actually we have:
> * increase first byte with the value of modem status bits
> * decrease "len"
> * put orig_len - 1 bytes of data starting from the buffer beggining
> This is evidently wrong.
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2011-09-27 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 15:22 [PATCH 1/2] tty/n_gsm: fix a bug in gsm_dlci_data_output (adaption = 2 case) Mikhail Kshevetskiy
2011-09-23 15:22 ` [PATCH 2/2] tty/n_gsm: avoid fifo overflow in gsm_dlci_data_output Mikhail Kshevetskiy
2011-09-27 10:59 ` Alan Cox
2011-09-27 10:58 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110927115804.40ab56dc@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mikhail.kshevetskiy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).