From: Greg KH <greg@kroah.com>
To: Oliver Neukum <oneukum@suse.de>
Cc: "Antti Palosaari" <crope@iki.fi>,
linux-serial@vger.kernel.org, linux-media@vger.kernel.org,
linux-usb@vger.kernel.org, "Bjørn Mork" <bjorn@mork.no>,
"James Courtier-Dutton" <james.dutton@gmail.com>,
HoP <jpetrous@gmail.com>, "István Váradi" <ivaradi@gmail.com>
Subject: Re: serial device name for smart card reader that is integrated to Anysee DVB USB device
Date: Wed, 5 Oct 2011 00:01:59 -0700 [thread overview]
Message-ID: <20111005070159.GA6896@kroah.com> (raw)
In-Reply-To: <201110050815.17949.oneukum@suse.de>
On Wed, Oct 05, 2011 at 08:15:17AM +0200, Oliver Neukum wrote:
> Am Mittwoch, 5. Oktober 2011, 07:58:51 schrieb Antti Palosaari:
> > On 10/05/2011 07:59 AM, Greg KH wrote:
>
> > > Why not just use the usb-serial core and then you get a ttyUSB* device
> > > node "for free"? It also should provide a lot of the basic tty
> > > infrastructure and ring buffer logic all ready to use.
> >
> > Since I don't see how I can access same platform data from DVB USB and
> > USB-serial driver (usb_set_intfdata). I asked that earlier, see:
> > http://www.mail-archive.com/linux-media@vger.kernel.org/msg36027.html
>
> Yes, and I'll have to give you the same answer as then.
>
> But, Greg, Antti makes a very valid point here. The generic code assumes that
> it owns intfdata, that is you cannot use it as is for access to anything that lacks
> its own interface. But this is not a fatal flaw. We can alter the generic code to use
> an accessor function the driver can provide and make it default to get/set_intfdata
>
> What do you think?
I totally forgot about that previous answer, I write too much email :)
Anyway, yes, if we can alter the core to make this work for this type of
device, that is probably much easier than having to write a whole tty
driver just for this one type of device. I'll gladly take such a patch.
thanks,
greg k-h
prev parent reply other threads:[~2011-10-05 7:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 21:22 serial device name for smart card reader that is integrated to Anysee DVB USB device Antti Palosaari
[not found] ` <4E8B7901.2050700-X3B1VOXEql0@public.gmane.org>
2011-10-05 4:59 ` Greg KH
2011-10-05 5:58 ` Antti Palosaari
2011-10-05 6:15 ` Oliver Neukum
2011-10-05 6:19 ` Antti Palosaari
2011-10-05 8:16 ` Oliver Neukum
[not found] ` <201110051016.06291.oneukum-l3A5Bk7waGM@public.gmane.org>
2011-10-14 17:32 ` Oliver Neukum
2011-12-13 16:30 ` Antti Palosaari
2011-12-13 17:41 ` Alan Cox
2011-10-05 7:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111005070159.GA6896@kroah.com \
--to=greg@kroah.com \
--cc=bjorn@mork.no \
--cc=crope@iki.fi \
--cc=ivaradi@gmail.com \
--cc=james.dutton@gmail.com \
--cc=jpetrous@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).