From: Alan Cox <alan@linux.intel.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, qi.wang@intel.com,
yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com
Subject: Re: [PATCH] 8250_pci: Fix kernel panic when pch_uart is disabled
Date: Wed, 12 Oct 2011 19:17:25 +0100 [thread overview]
Message-ID: <20111012191725.179db127@bob.linux.org.uk> (raw)
In-Reply-To: <1317962389-21786-1-git-send-email-tomoya-linux@dsn.lapis-semi.com>
On Fri, 7 Oct 2011 13:39:49 +0900
Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com> wrote:
> Currently, ".setup" function is not set.
> As a result, when detecting our IOH's uart device without pch_uart,
> kernel panic occurs at the following of pciserial_init_ports().
>
> for (i = 0; i < nr_ports; i++) {
> if (quirk->setup(priv, board, &serial_port, i))
> break;
>
> So, this patch adds the ".setup" function.
> We can use pci_default_setup because our IOH's uart is compatible
> with 16550.
>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2011-10-12 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 4:39 [PATCH] 8250_pci: Fix kernel panic when pch_uart is disabled Tomoya MORINAGA
2011-10-12 18:17 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012191725.179db127@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya-linux@dsn.lapis-semi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).