* [PATCH] 8250_pci: Fix kernel panic when pch_uart is disabled
@ 2011-10-07 4:39 Tomoya MORINAGA
2011-10-12 18:17 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Tomoya MORINAGA @ 2011-10-07 4:39 UTC (permalink / raw)
To: Alan Cox, gregkh, linux-kernel, linux-serial
Cc: qi.wang, yong.y.wang, joel.clark, kok.howg.ewe, Tomoya MORINAGA
Currently, ".setup" function is not set.
As a result, when detecting our IOH's uart device without pch_uart, kernel panic
occurs at the following of pciserial_init_ports().
for (i = 0; i < nr_ports; i++) {
if (quirk->setup(priv, board, &serial_port, i))
break;
So, this patch adds the ".setup" function.
We can use pci_default_setup because our IOH's uart is compatible with 16550.
Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
---
drivers/tty/serial/8250_pci.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/8250_pci.c b/drivers/tty/serial/8250_pci.c
index 3abeca2..55677b9 100644
--- a/drivers/tty/serial/8250_pci.c
+++ b/drivers/tty/serial/8250_pci.c
@@ -1558,46 +1558,55 @@ static struct pci_serial_quirk pci_serial_quirks[] __refdata = {
.vendor = PCI_VENDOR_ID_INTEL,
.device = 0x8811,
.init = pci_eg20t_init,
+ .setup = pci_default_setup,
},
{
.vendor = PCI_VENDOR_ID_INTEL,
.device = 0x8812,
.init = pci_eg20t_init,
+ .setup = pci_default_setup,
},
{
.vendor = PCI_VENDOR_ID_INTEL,
.device = 0x8813,
.init = pci_eg20t_init,
+ .setup = pci_default_setup,
},
{
.vendor = PCI_VENDOR_ID_INTEL,
.device = 0x8814,
.init = pci_eg20t_init,
+ .setup = pci_default_setup,
},
{
.vendor = 0x10DB,
.device = 0x8027,
.init = pci_eg20t_init,
+ .setup = pci_default_setup,
},
{
.vendor = 0x10DB,
.device = 0x8028,
.init = pci_eg20t_init,
+ .setup = pci_default_setup,
},
{
.vendor = 0x10DB,
.device = 0x8029,
.init = pci_eg20t_init,
+ .setup = pci_default_setup,
},
{
.vendor = 0x10DB,
.device = 0x800C,
.init = pci_eg20t_init,
+ .setup = pci_default_setup,
},
{
.vendor = 0x10DB,
.device = 0x800D,
.init = pci_eg20t_init,
+ .setup = pci_default_setup,
},
/*
* Cronyx Omega PCI (PLX-chip based)
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] 8250_pci: Fix kernel panic when pch_uart is disabled
2011-10-07 4:39 [PATCH] 8250_pci: Fix kernel panic when pch_uart is disabled Tomoya MORINAGA
@ 2011-10-12 18:17 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2011-10-12 18:17 UTC (permalink / raw)
To: Tomoya MORINAGA
Cc: gregkh, linux-kernel, linux-serial, qi.wang, yong.y.wang,
joel.clark, kok.howg.ewe
On Fri, 7 Oct 2011 13:39:49 +0900
Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com> wrote:
> Currently, ".setup" function is not set.
> As a result, when detecting our IOH's uart device without pch_uart,
> kernel panic occurs at the following of pciserial_init_ports().
>
> for (i = 0; i < nr_ports; i++) {
> if (quirk->setup(priv, board, &serial_port, i))
> break;
>
> So, this patch adds the ".setup" function.
> We can use pci_default_setup because our IOH's uart is compatible
> with 16550.
>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
Acked-by: Alan Cox <alan@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-12 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-07 4:39 [PATCH] 8250_pci: Fix kernel panic when pch_uart is disabled Tomoya MORINAGA
2011-10-12 18:17 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).