From: Greg KH <gregkh@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Greg KH <greg@kroah.com>, Nhan H Mai <nhan.h.mai@intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
alan@linux.intel.com
Subject: Re: [PATCH] serial/8250_pci: add a quirk for the kt serial controller
Date: Tue, 25 Oct 2011 22:51:06 +0200 [thread overview]
Message-ID: <20111025205106.GD7234@suse.de> (raw)
In-Reply-To: <1319573794.9320.15.camel@dwillia2-mobl>
On Tue, Oct 25, 2011 at 01:16:34PM -0700, Dan Williams wrote:
> From: Dan Williams <dan.j.williams@intel.com>
> Date: Sun, 23 Oct 2011 15:06:24 -0700
> Subject: [PATCH v2] serial/8250_pci: add a quirk for the kt serial controller
>
> Workaround dropped notifications in the iir register. Prevent reads
> coincident with new interrupt notifications by reading the iir at most
> once per interrupt.
>
> Reported-by: Nhan H Mai <nhan.h.mai@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Much better.
But.
Do you really think I can apply a patch that looks like this above? I
have to edit the text of the email before I apply it.
Now I'm a bit grumpy about this at the moment as Linus yelled at me for
patches where I missed this on a few for the 3.2 merge window, so I'm
going to push back on people now very hard.
Please send this in a format that I can run 'git am' on the email you
send me. I could not do that here, otherwise we would end up with a
duplicate header in the changelog message.
Yes, it makes you do a bit more work, but when you are handling
thousands of patches like me, you scale better than I do :)
Actually, it's just making you do it properly, along with everyone else,
which is a good thing, right?
thanks,
greg k-h
next prev parent reply other threads:[~2011-10-25 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 22:27 [PATCH] serial/8250_pci: add a quirk for the kt serial controller Dan Williams
2011-10-25 2:28 ` Greg KH
2011-10-25 20:16 ` Dan Williams
2011-10-25 20:51 ` Greg KH [this message]
2011-10-25 22:52 ` Williams, Dan J
2011-11-03 16:34 ` Williams, Dan J
2011-11-15 19:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111025205106.GD7234@suse.de \
--to=gregkh@suse.de \
--cc=alan@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nhan.h.mai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).