From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH 02/14] ARM : SAMSUNG : Add RS485 support. Date: Tue, 1 Nov 2011 19:55:17 +0000 Message-ID: <20111101195517.5334482c@bob.linux.org.uk> References: <1319255194-4799-1-git-send-email-paul.s.schilling@gmail.com> <20111101121851.7d393277@bob.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga09.intel.com ([134.134.136.24]:42518 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829Ab1KAToe convert rfc822-to-8bit (ORCPT ); Tue, 1 Nov 2011 15:44:34 -0400 In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Paul Schilling Cc: Ben Dooks , Kukjin Kim , Russell King , Greg Kroah-Hartman , Boojin Kim , Nicolas Pitre , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org > The opinion part... =C2=A0I needed a timer to switch from transmit to > receive after the FIFO was empty. =C2=A0I started by using the low > resolution timer using jiffies first. =C2=A0I found that wasn't high = enough > resolution, so I switched to the Linux HRT. Currently I have both > versions that can be selected by conditional compile. =C2=A0Should I > just remove the low resolution timer completely or leave it in. I would just remove the low res one. They should degrade to low res timer equivalence anyway. > Second, I have a chunk of code that if it could be made to work > could off load the receiving to DMA up to the last couple of bytes > then switch back to interrupts for the token byte. =C2=A0Should I lea= ve > that code in a #if 0 statement or should I just delete it. Is it something that you are likely to debug or someone is going to debug shortly ? -- To unsubscribe from this list: send the line "unsubscribe linux-serial"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html