From: Richard Zhao <richard.zhao@linaro.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: kernel@pengutronix.de, eric.miao@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, alan@linux.intel.com
Subject: Re: [PATCH 1/1] serial: imx: convert to clk_prepare/clk_unprepare
Date: Thu, 10 Nov 2011 16:24:33 +0800 [thread overview]
Message-ID: <20111110082432.GA14617@b20223-02.ap.freescale.net> (raw)
In-Reply-To: <20111110080641.GT16886@pengutronix.de>
On Thu, Nov 10, 2011 at 09:06:41AM +0100, Sascha Hauer wrote:
> On Thu, Nov 10, 2011 at 12:59:18PM +0800, Richard Zhao wrote:
> > Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
> > ---
> > drivers/tty/serial/imx.c | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> > index 163fc90..22fd9c8 100644
> > --- a/drivers/tty/serial/imx.c
> > +++ b/drivers/tty/serial/imx.c
> > @@ -1390,6 +1390,7 @@ static int serial_imx_probe(struct platform_device *pdev)
> > ret = PTR_ERR(sport->clk);
> > goto unmap;
> > }
> > + clk_prepare(sport->clk);
> > clk_enable(sport->clk);
> >
> > sport->port.uartclk = clk_get_rate(sport->clk);
> > @@ -1415,6 +1416,7 @@ deinit:
> > clkput:
> > clk_put(sport->clk);
> > clk_disable(sport->clk);
> > + clk_unprepare(sport->clk);
>
> Ouch, clk_put before clk_disable? This is is bug. Care to fix it?
hmm.. I'll fix the two bugs in my next version patch.
>
> > unmap:
> > iounmap(sport->port.membase);
> > free:
> > @@ -1438,6 +1440,7 @@ static int serial_imx_remove(struct platform_device *pdev)
> > }
> >
> > clk_disable(sport->clk);
> > + clk_unprepare(sport->clk);
> >
>
> Here clk_put is missing, another bug.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
prev parent reply other threads:[~2011-11-10 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 4:59 [PATCH 1/1] serial: imx: convert to clk_prepare/clk_unprepare Richard Zhao
2011-11-10 8:06 ` Sascha Hauer
2011-11-10 8:24 ` Richard Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110082432.GA14617@b20223-02.ap.freescale.net \
--to=richard.zhao@linaro.org \
--cc=alan@linux.intel.com \
--cc=eric.miao@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox