From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 5/8] serial: 8250: reject delaying RTS with RS485 Date: Thu, 17 Nov 2011 11:14:26 +0100 Message-ID: <20111117101426.GD2535@pengutronix.de> References: <1321460685-15753-1-git-send-email-w.sang@pengutronix.de> <1321460685-15753-6-git-send-email-w.sang@pengutronix.de> <4EC4D72F.8030702@evidence.eu.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GyRA7555PLgSTuth" Return-path: Content-Disposition: inline In-Reply-To: <4EC4D72F.8030702@evidence.eu.com> Sender: linux-kernel-owner@vger.kernel.org To: Claudio Scordino Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Cox , Juergen Beisert , Matthias Fuchs List-Id: linux-serial@vger.kernel.org --GyRA7555PLgSTuth Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > The delay must not necessarily be done by hardware. The drivers/tty/seria= l/crisv10.c=20 > driver, for example, delays through a msleep. >=20 > I don't know if having a software delay in this driver can make sense in = some particular=20 > circumstance. Uuuh, I would be against software delays for the same reason why we don't accept software based direction switching: No guarantees. msleep() might easily delay longer than what was requested. Or are delay_rts values to be interpreted as "delay at least"? Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --GyRA7555PLgSTuth Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk7E3oIACgkQD27XaX1/VRvfuwCgrAyHc88uIh2OcnAZD2wRucfs stMAn0rE9s0VfJ/cABtCypX3P/l35XPz =bl6p -----END PGP SIGNATURE----- --GyRA7555PLgSTuth--