* [PATCH 1/2] serial/imx: propagate error of platform_driver_register in init routine
@ 2011-11-22 13:22 Uwe Kleine-König
2011-11-22 13:22 ` [PATCH 2/2] serial/mxs-auart: only wake up tty layer once Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2011-11-22 13:22 UTC (permalink / raw)
To: kernel, linux-serial; +Cc: Alan Cox
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/tty/serial/imx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 163fc90..962cafa 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1476,7 +1476,7 @@ static int __init imx_serial_init(void)
if (ret != 0)
uart_unregister_driver(&imx_reg);
- return 0;
+ return ret;
}
static void __exit imx_serial_exit(void)
--
1.7.7.3
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] serial/mxs-auart: only wake up tty layer once
2011-11-22 13:22 [PATCH 1/2] serial/imx: propagate error of platform_driver_register in init routine Uwe Kleine-König
@ 2011-11-22 13:22 ` Uwe Kleine-König
2011-11-23 11:40 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2011-11-22 13:22 UTC (permalink / raw)
To: kernel, linux-serial; +Cc: Alan Cox
There is no need to call uart_write_wakeup after each character send.
Once at the end of the write sequence is enough.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/tty/serial/mxs-auart.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 7e02c9c..076169f 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -145,11 +145,12 @@ static inline void mxs_auart_tx_chars(struct mxs_auart_port *s)
writel(xmit->buf[xmit->tail],
s->port.membase + AUART_DATA);
xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
- if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
- uart_write_wakeup(&s->port);
} else
break;
}
+ if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
+ uart_write_wakeup(&s->port);
+
if (uart_circ_empty(&(s->port.state->xmit)))
writel(AUART_INTR_TXIEN,
s->port.membase + AUART_INTR_CLR);
--
1.7.7.3
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-23 14:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-22 13:22 [PATCH 1/2] serial/imx: propagate error of platform_driver_register in init routine Uwe Kleine-König
2011-11-22 13:22 ` [PATCH 2/2] serial/mxs-auart: only wake up tty layer once Uwe Kleine-König
2011-11-23 11:40 ` Alan Cox
2011-11-23 11:41 ` Uwe Kleine-König
2011-11-23 14:56 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).