Re: [PATCH] amba-pl011: clear previous interrupts before request_irq

Alan Cox
2012-01-18T11:39:54Z

> /*
> + * Clear previous interrupts before installing interrupt handler
> + */
> + spin_lock_irq(&uap->port.lock);
> + uap->im = 0;
> + writew(uap->im, uap->port.membase + UART011_IMSC);
> + writew(0xffff, uap->port.membase + UART011_ICR);
> + spin_unlock_irq(&uap->port.lock);

I'm confused why you use spin_lock_irq before you've enabled the IRQ in
the first place but looks fine.

Alan