Re: [PATCH] amba-pl011: clear previous interrupts before request_irq

Shreshtha Kumar SAHU
2012-01-19T11:16:19Z

On Wed, Jan 18, 2012 at 12:41:00 +0100, Alan Cox wrote:
> > /*
> > + * Clear previous interrupts before installing interrupt handler
> > + */
> > + spin_lock_irq(&uap->port.lock);
> > + uap->im = 0;
> > + writew(uap->im, uap->port.membase + UART011_IMSC);
> > + writew(0xffff, uap->port.membase + UART011_ICR);
> > + spin_unlock_irq(&uap->port.lock);
>
> I'm confused why you use spin_lock_irq before you've enabled the IRQ in
> the first place but looks fine.
>
> Alan
Yes, spin_lock_irq for the port is not required as request_irq is not yet
called for the port.

Thanks and Regards,
Shreshtha