From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [Patch] tty: fix a build failure on sparc
Date: Fri, 3 Feb 2012 14:46:09 -0500
Message-ID: <20120203194608.GA23948@windriver.com>
References: <1328246540-5824-1-git-send-email-xiyou.wangcong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Return-path: <linux-serial-owner@vger.kernel.org>
Received: from mail.windriver.com ([147.11.1.11]:50517 "EHLO
	mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754126Ab2BCTqU (ORCPT
	<rfc822;linux-serial@vger.kernel.org>);
	Fri, 3 Feb 2012 14:46:20 -0500
Content-Disposition: inline
In-Reply-To: <1328246540-5824-1-git-send-email-xiyou.wangcong@gmail.com>
Sender: linux-serial-owner@vger.kernel.org
List-Id: linux-serial@vger.kernel.org
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Alan Cox <alan@linux.intel.com>, Jamie Iles <jamie@jamieiles.com>, Stephen Warren <swarren@nvidia.com>, linux-serial@vger.kernel.org

[Resending with updated address for Greg]

On 12-02-03 12:22 AM, Cong Wang wrote:
> On sparc, there is a build failure:
> 
> drivers/tty/serial/8250/8250.c:48:21: error: suncore.h: No such file or directory
> drivers/tty/serial/8250/8250.c:3275: error: implicit declaration of function 'sunserial_register_minors'
> drivers/tty/serial/8250/8250.c:3305: error: implicit declaration of function 'sunserial_unregister_minors'
> 
> this is due to commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b
> (serial: group all the 8250 related code together) moved these files
> into 8250/ subdirectory, but forgot to change the reference
> to drivers/tty/serial/suncore.h.

Thanks, I explicitly left sunsu out of the move but missed
that 8250 was sourcing its related header.  I did defconfig
builds, but in going back to check, I see that neither sparc
32/64 defconfig enable 8250 by default, so those builds didn't
help me much at all...  :(

Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>

> 
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
> 
> ---
> diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
> index 9f50c4e..9b7336f 100644
> --- a/drivers/tty/serial/8250/8250.c
> +++ b/drivers/tty/serial/8250/8250.c
> @@ -45,7 +45,7 @@
>  #include "8250.h"
>  
>  #ifdef CONFIG_SPARC
> -#include "suncore.h"
> +#include "../suncore.h"
>  #endif
>  
>  /*