From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP2xxx: PM: fix OMAP2xxx-specific UART idle bug in v3.3 Date: Thu, 9 Feb 2012 17:52:25 -0800 Message-ID: <20120210015225.GO1426@atomide.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:14215 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758695Ab2BJBwd (ORCPT ); Thu, 9 Feb 2012 20:52:33 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Paul Walmsley Cc: Mark Brown , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Olof Johansson , Jarkko Nikula , Greg KH , Kevin Hilman , Grazvydas Ignotas , Russell King - ARM Linux , linux-serial@vger.kernel.org * Paul Walmsley [120209 16:52]: > > [ This patch is targeted for v3.3-rc ] > > On OMAP2420-based systems, the PM code ignores the state of the UART > functional clocks when determining what idle state to enter. This > breaks the serial port now that the UART driver's clock behavior can > be controlled via the PM autosuspend timeout. > > To fix, remove the special-case idle handling for the UARTs in the > OMAP2420/2430 PM idle code added by commit > 4af4016c53f52b26461b8030211f8427a58fa5ed ("OMAP3: PM: UART: disable > clocks when idle and off-mode support"). > > Tested on Nokia N800. This patch is a collaboration between Tony > Lindgren and Paul Walmsley . Glad to see this piece of code finally gone with runtime PM :) Applying into fixes. Regards, Tony