From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] OMAP: serial: Release the claimed memory region in remove Date: Sat, 11 Feb 2012 11:27:22 +0000 Message-ID: <20120211112721.GA21453@sirena.org.uk> References: <1328945607-4025-1-git-send-email-shubhrajyoti@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1328945607-4025-1-git-send-email-shubhrajyoti@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Shubhrajyoti D Cc: linux-serial@vger.kernel.org, "Govindraj.R" , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org On Sat, Feb 11, 2012 at 01:03:27PM +0530, Shubhrajyoti D wrote: > Currently the memory region is not released the folowing error is > observed. > /testsuites # insmod omap-serial.ko > [ 130.746917] omap_uart omap_uart.0: memory region already claimed > [ 130.753143] omap_uart: probe of omap_uart.0 failed with error -16 It'd be better yet to use the devm_ functions to prevent such issues recurring in future.