From mboxrd@z Thu Jan 1 00:00:00 1970 From: Feng Tang Subject: Re: [PATCH 0/4] pch_uart: Cleanups, board quirks, and user uartclk parameter Date: Wed, 22 Feb 2012 17:25:40 +0800 Message-ID: <20120222092540.GA27282@feng-i7> References: <4F4462B8.6030607@linux.intel.com> <4F448DAA.6000207@linux.intel.com> <4F44AE57.10302@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <4F44AE57.10302@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Darren Hart Cc: Tomoya MORINAGA , Linux Kernel Mailing List , Greg Kroah-Hartman , Alan Cox , linux-serial@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Wed, Feb 22, 2012 at 12:59:03AM -0800, Darren Hart wrote: >=20 >=20 > On 02/22/2012 12:16 AM, Tomoya MORINAGA wrote: > > 2012=E5=B9=B42=E6=9C=8822=E6=97=A515:39 Darren Hart : > >> We can add a patch to this series that sets the > >> default to 192MHz, drops the CM-iTC quirk, and does nothing in pch= _phub > >> probe for the FRI2. > >=20 > > If you set the clock of pch_uart as 64MHz, > > do you need to add quirk for FRI2 to pch_phub so as to provide 64MH= z clock? >=20 > I admit the value of pch_phub eludes me a bit. In my case, the firmwa= re > sets up the CLKCFG register, so there is no need to set it manually > after boot. Instead, I'm making sure the pch_uart driver defaults to > what the firmware sets up. I think long term wise, we should suggest BIOS vendor to set the UART c= lk to 192MHz in chipset's release notes, since 192MHz works on Darren's, Tomoya's and my boards. Thanks, =46eng >=20 > --=20 > Darren Hart > Intel Open Source Technology Center > Yocto Project - Linux Kernel