From: Greg KH <gregkh@linuxfoundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [RFC PATCH] vt:tackle kbd_table
Date: Mon, 27 Feb 2012 17:11:00 -0800 [thread overview]
Message-ID: <20120228011100.GA18378@kroah.com> (raw)
In-Reply-To: <20120227160739.8711.95344.stgit@bob.linux.org.uk>
On Mon, Feb 27, 2012 at 04:10:23PM +0000, Alan Cox wrote:
> This could do with some extra eyes and double checking. With this one out of
> the day we can start to make a dent in the console locking logic and thus
> eventually into tty_lock().
>
> From: Alan Cox <alan@linux.intel.com>
>
> Keyboard struct lifetime is easy, but the locking is not and is completely
> ignored by the existing code. Tackle this one head on
>
> - Make the kbd_table private so we can run down all direct users
> - Hoick the relevant ioctl handlers into the keyboard layer
> - Lock them with the keyboard lock so they don't change mid keypress
> - Add helpers for things like console stop/start so we isolate the poking
> around properly
> - Tweak the braille console so it still builds
The drivers/staging/speakup/main.c code also would need to be tweaked in
this same manner, but that's not a big deal.
Other than that, at first glance, this looks good, nice job. Care to
make the speakup change and resend it so we can try it out in
linux-next?
greg k-h
prev parent reply other threads:[~2012-02-28 1:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 16:10 [RFC PATCH] vt:tackle kbd_table Alan Cox
2012-02-28 1:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228011100.GA18378@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).