From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Chanho Min <chanho0207@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Shreshtha Kumar Sahu <shreshthakumar.sahu@stericsson.com>,
"Kim, Jong-Sung" <neidhard.kim@lge.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] Clear previous interrupts after fifo is disabled
Date: Tue, 28 Feb 2012 10:23:37 +0000 [thread overview]
Message-ID: <20120228102337.GF18045@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAOAMb1Cqfrk-b-yd1CMt2Hac7_j3i6WL8D8yQJDWjg_S18dAsw@mail.gmail.com>
On Tue, Feb 28, 2012 at 06:46:12PM +0900, Chanho Min wrote:
> > Because the flags are manipulated to give the illusion of a one byte
> > FIFO, as stated in the TRM.
> Yes. It is the problem that rx interrupt is pended with this status as
> I mentioned.
Which is why my patch explicitly clears the receive interrupt status
before requesting the interrupt. Have you read my patch?
> > And we don't set the mask register to 1 until later.
> In the last part of startup, set to 1. Interrupt can be occurred just
> after it.
>
> uap->im = UART011_RTIM;
> if (!pl011_dma_rx_running(uap))
> uap->im |= UART011_RXIM;
> writew(uap->im, uap->port.membase + UART011_IMSC);
>
> > But we want to do the transmit interrupt provocation with the FIFO disabled.
> I know. It's test only.
Wrong, it's fundamental to the UARTs operation.
next prev parent reply other threads:[~2012-02-28 10:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 9:30 [PATCH] Clear previous interrupts after fifo is disabled Chanho Min
2012-02-27 10:45 ` Linus Walleij
2012-02-27 10:48 ` Russell King - ARM Linux
2012-02-27 11:02 ` Russell King - ARM Linux
2012-02-27 13:54 ` Linus Walleij
2012-02-28 1:35 ` Chanho Min
2012-02-28 8:35 ` Russell King - ARM Linux
2012-02-28 9:16 ` Chanho Min
2012-02-28 9:21 ` Russell King - ARM Linux
2012-02-28 9:46 ` Chanho Min
2012-02-28 10:23 ` Russell King - ARM Linux [this message]
2012-02-29 2:47 ` Chanho Min
2012-03-08 9:02 ` Kim, Jong-Sung
2012-03-08 18:49 ` Greg Kroah-Hartman
2012-03-09 16:34 ` Linus Walleij
2012-03-09 16:37 ` Greg Kroah-Hartman
2012-03-10 2:14 ` Chanho Min
2012-03-12 1:24 ` Kim, Jong-Sung
2012-03-12 8:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228102337.GF18045@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alan@linux.intel.com \
--cc=chanho0207@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=neidhard.kim@lge.com \
--cc=shreshthakumar.sahu@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).