From: Alan Cox <alan@linux.intel.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 5/7] serial: remove back and forth conversions in serial_out_sync
Date: Fri, 2 Mar 2012 11:22:04 +0000 [thread overview]
Message-ID: <20120302112204.4f990c78@bob.linux.org.uk> (raw)
In-Reply-To: <1330655603-5268-6-git-send-email-paul.gortmaker@windriver.com>
On Thu, 1 Mar 2012 21:33:21 -0500
Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> The two callers to serial_out_sync() have a struct port right
> there in scope, but then pass in a struct 8250_port which then
> is locally resolved to a struct port.
This change I don't like. It means serial_out_sync and serial_out end
up with different parameters which seems odd to say the least. You then
extend this oddity by adding helpers for port_in/out but not the sync
one.
Otherwise it all looks good to me.
Alan
next prev parent reply other threads:[~2012-03-02 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 2:33 [RFC PATCH 0/7] serial: cleanups that strive to do nothing Paul Gortmaker
2012-03-02 2:33 ` [PATCH 1/7] serial: delete last unused traces of pausing I/O in 8250 Paul Gortmaker
2012-03-02 2:33 ` [PATCH 2/7] serial: make 8250's serial_in shareable to other drivers Paul Gortmaker
2012-03-02 2:33 ` [PATCH 3/7] serial: delete useless void casts in 8250.c Paul Gortmaker
2012-03-02 2:33 ` [PATCH 4/7] serial: reduce number of indirections in 8250 code Paul Gortmaker
2012-03-02 2:33 ` [PATCH 5/7] serial: remove back and forth conversions in serial_out_sync Paul Gortmaker
2012-03-02 11:22 ` Alan Cox [this message]
2012-03-02 14:13 ` Paul Gortmaker
2012-03-02 2:33 ` [PATCH 6/7] serial: introduce generic port in/out helpers Paul Gortmaker
2012-03-02 2:33 ` [PATCH 7/7] serial: use serial_port_in/out vs serial_in/out in 8250 Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302112204.4f990c78@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).