From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: matthieu castet <castet.matthieu@free.fr>
Cc: linux-serial@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Toby Gray <toby.gray@realvnc.com>,
Stefan Bigler <stefan.bigler@keymile.com>
Subject: Re: [PATCH 0/9] [RFC] tty : make receive_room internal to N_TTY line discipline
Date: Mon, 5 Mar 2012 23:42:34 +0000 [thread overview]
Message-ID: <20120305234234.12df898f@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20120304190513.0b7a881b@mat-laptop>
I had a bigger dig into this and I think the path to make it workable is
probably
- Finish getting rid of the tty_lock (ie the last remnants of the BKL)
- At that point we can rework the logic in tty_ldisc a bit and you can
then hold tty->ldisc_mutex across the entire ldisc_receive. That will
be a natural sane way to lock the ldisc.
- Once that is in place it is possible to fix TIOCSTI and selection using
that mutex to single thread.
- Which then lets you fix the receive_room logic because its all running
under a sensible locking model.
I don't see any shortcuts here.
Alan
prev parent reply other threads:[~2012-03-05 23:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 18:05 [PATCH 0/9] [RFC] tty : make receive_room internal to N_TTY line discipline matthieu castet
2012-03-05 23:42 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305234234.12df898f@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=balbi@ti.com \
--cc=castet.matthieu@free.fr \
--cc=linux-serial@vger.kernel.org \
--cc=stefan.bigler@keymile.com \
--cc=toby.gray@realvnc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox